Skip to content

[18.09] thunderbird: 60.5.1 -> 60.6.0 #58352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2019
Merged

[18.09] thunderbird: 60.5.1 -> 60.6.0 #58352

merged 2 commits into from
Apr 12, 2019
+2 −2

Conversation

andir
Copy link
Member

@andir andir commented Mar 26, 2019

Motivation for this change

Backport of the backport #58034 :-)

cc @Mic92 @taku0

I haven't built it yet - lack of (mobile) computation power & no access to private keys..

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

taku0 added 2 commits March 26, 2019 11:19
@taku0 @andir
thunderbird: 60.5.1 -> 60.5.2
38063aa 
(cherry picked from commit 202f713)
@taku0 @andir
thunderbird: 60.5.2 -> 60.6.0
9b6eddb 
(cherry picked from commit 3c83eb4)
@GrahamcOfBorg GrahamcOfBorg requested review from edolstra and nbp March 26, 2019 10:45
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 26, 2019
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@taku0
Copy link
Contributor

taku0 commented Apr 12, 2019

It works.

git fetch --force upstream pull/58352/head:pull_58352
git checkout pull_58352
nix-build --keep-failed --keep-going -I nixpkgs=. -o thunderbird -A pkgs.thunderbird
./thunderbird/bin/thunderbird

@andir andir merged commit 28c1496 into NixOS:release-18.09 Apr 12, 2019
@andir andir deleted the 18.09/thunderbird branch April 12, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

@nbp nbp

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @taku0 @infinisil @GrahamcOfBorg