Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: storePathToLayer use runtimeShell in script #58350

Merged
merged 1 commit into from
Apr 6, 2019
Merged

dockerTools: storePathToLayer use runtimeShell in script #58350

merged 1 commit into from
Apr 6, 2019
+2 −2

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Just a fix so docker images correctly build on systems that are not nixos based

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

dockerTools: storePathToLayer use runtimeShell in script

Verified

This commit was signed with the committer’s verified signature.
primeos Michael Weiss
GPG key ID: 5BE487C4D4771D83
Verified
Learn about vigilant mode
5d429f6
@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 26, 2019
@offlinehacker offlinehacker requested a review from grahamc March 26, 2019 13:40
@nlewo
Copy link
Member

nlewo commented Mar 28, 2019

@GrahamcOfBorg test docker-tools

@nlewo nlewo merged commit a8beff9 into NixOS:master Apr 6, 2019
@nlewo
Copy link
Member

nlewo commented Apr 6, 2019

Backported to 19.03 in 0d8ecd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @nlewo @GrahamcOfBorg