Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clementine: update to qt5 #58353

Merged
merged 1 commit into from Mar 27, 2019
Merged

clementine: update to qt5 #58353

merged 1 commit into from Mar 27, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

thinked that qt5 was able to automatically include transparency in application. not the case, but having qt5 rather qt4 should be better.

Things done

replaced qt4 by qt5, with libsforqt5.callpackage rather than just callpackage

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Mar 27, 2019

@GrahamcOfBorg build clementine

@Ma27 Ma27 merged commit b4ca0e4 into NixOS:master Mar 27, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 27, 2019

@marius851000 thanks!

@kini
Copy link
Member

kini commented May 17, 2020 •
edited

The binary produced by the derivation says that it is using Qt 4.8.7 (when I run it and click "About Qt..." in the Help menu), even though it's built with libsForQt5.callPackage. ldd -v on the binary also shows it's linking to Qt 4.8.7 libs, not Qt 5.

I think the dependency on liblastfm (which is a Qt4 lib in nixpkgs at the moment, though I am trying to port it to Qt5 now) is pulling in Qt 4.8, and Qt 5 is not pulled in because it is never used in the build. So it seems to me that the only thing this PR does is obscure the fact that the package depends on Qt4.

What do you think?

@kini kini mentioned this pull request May 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marius851000 @Ma27 @kini @GrahamcOfBorg