Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mailcatcher: init module for existing package #58432

Merged
merged 2 commits into from Mar 27, 2019
Merged

nixos/mailcatcher: init module for existing package #58432

merged 2 commits into from Mar 27, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 27, 2019 •
edited

Motivation for this change

I'm interested in running mailcatcher as a system service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Mar 27, 2019 •
edited

@GrahamcOfBorg test mailcatcher

Ma27
Ma27 reviewed Mar 27, 2019
View reviewed changes
nixos/modules/services/mail/mailcatcher.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/mailcatcher.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/mailcatcher.nix Outdated Show resolved Hide resolved
@aanderse aanderse force-pushed the mailcatcher branch 2 times, most recently from 7141024 to 6180bd7 Compare March 27, 2019 13:34
@Ma27 Ma27 merged commit 3fc3096 into NixOS:master Mar 27, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 27, 2019

@aanderse thanks!

@aanderse aanderse deleted the mailcatcher branch March 27, 2019 15:45
@aanderse
Copy link
Member Author

@Ma27 If you don't mind would you please also merge #56575? Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @Ma27 @GrahamcOfBorg