Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performous: fix build by using boost 166 #58418

Merged
merged 1 commit into from Mar 27, 2019
Merged

performous: fix build by using boost 166 #58418

merged 1 commit into from Mar 27, 2019

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 27, 2019

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 27, 2019
@veprbl
Copy link
Member

veprbl commented Mar 27, 2019

@GrahamcOfBorg build performous

@veprbl veprbl merged commit 910c1d0 into NixOS:master Mar 27, 2019
veprbl pushed a commit that referenced this pull request Mar 27, 2019
@ajs124 @veprbl
performous: fix build by using boost 166 (#58418)
42fece1 
(cherry picked from commit 910c1d0)
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 27, 2019
veprbl pushed a commit that referenced this pull request Mar 27, 2019
@ajs124 @veprbl
performous: fix build by using boost 166 (#58418)
2c54e2d 
(cherry picked from commit 910c1d0)
@ajs124 ajs124 deleted the performous_fix_build branch March 27, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @veprbl @GrahamcOfBorg