-
-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect size bounds checks in vehicle viewport hash scan in ViewportAddVehicles #6618
Comments
This issue has been automatically marked as stale because it has not had any activity in the last two months. |
@JGRennison Is this something you'd care to PR? |
I'll see what I can do. For reference the commit in my fork is JGRennison/OpenTTD-patches@d3a1e80 |
Fix incorrect bounds check in ViewportAddVehicles in the case where the viewport width or height is less than the hash wraparound distance, however the two bounds still map to the same hash bucket due to discarding the lower coordinate bits, such that the intermediary hash buckets are incorrectly not iterated.
@JGRennison : sorry to dig up an old issue, but the patch you mention, has that survived the test of time? As in, can we just backport it upstream? I can imagine if you did fixes on it over time, hence the question :) Tnx! |
|
JGR opened the ticket and wrote:
Reported version: trunk
Operating system: All
This issue was imported from FlySpray: https://bugs.openttd.org/task/6618
The text was updated successfully, but these errors were encountered: