Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libssh: 0.8.5 -> 0.8.7 #58307

Merged
merged 1 commit into from Apr 16, 2019
Merged

libssh: 0.8.5 -> 0.8.7 #58307

merged 1 commit into from Apr 16, 2019

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libssh/versions.

meta.description for libssh is: '"SSH client library"'.

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

1661 total rebuild path(s)

730 package rebuild(s)

474 x86_64-linux rebuild(s)
420 i686-linux rebuild(s)
106 x86_64-darwin rebuild(s)
661 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
acoustidFingerprinter
adapta-gtk-theme
adoptopenjdk-bin
adoptopenjdk-hotspot-bin-11
adoptopenjdk-jre-bin
adoptopenjdk-jre-hotspot-bin-11
adoptopenjdk-jre-openj9-bin-11
adoptopenjdk-openj9-bin-11
aegisub
ahoviewer
airtame
akregator
alchemy
alloy
alloy4
alloy5
amarok
amarok-kf5
ammonite
anki
antlr3
antlr3_4
antlr3_5
antlr4
antlr4_7
apacheKafka
apacheKafka_0_10
apacheKafka_0_11
apacheKafka_0_9
apacheKafka_1_0
apacheKafka_1_1
apacheKafka_2_0
apacheKafka_2_1
arc-theme
aspectj
astrolabe-generator
atlassian-cli
attract-mode
audacious
audaciousQt5
audacity
audio-recorder
avxsynth
baresip
basex
beets
belle-sip
bfg-repo-cleaner
bftools
bino3d

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/mfi4wdc3m776545ci0xvx5n4cazzvz5y-libssh-0.8.7 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A libssh https://github.com/r-ryantm/nixpkgs/archive/bf2bb184e232b986e16bab3c80f487211c915917.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/mfi4wdc3m776545ci0xvx5n4cazzvz5y-libssh-0.8.7
ls -la /nix/store/mfi4wdc3m776545ci0xvx5n4cazzvz5y-libssh-0.8.7/bin

cc @svanderburg for testing.

@r-ryantm
libssh: 0.8.5 -> 0.8.7
bf2bb18 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libssh/versions
@markuskowa
Copy link
Member

@GrahamcOfBorg eval

@xeji
Copy link
Contributor

xeji commented Mar 30, 2019

@GrahamcOfBorg eval

1 similar comment
@xeji
Copy link
Contributor

xeji commented Apr 10, 2019

@GrahamcOfBorg eval

@FRidh FRidh merged commit 25ebfe2 into NixOS:staging Apr 16, 2019
@matthewbauer
Copy link
Member

It looks like this has a bad .cmake file:

https://hydra.nixos.org/build/92448979/nixlog/2/tail

The file at /nix/store/06gmnf6lb9dz2jm7kjmk65plw5ck1g1z-libssh-0.8.7-dev/lib/cmake/libssh/libssh-config.cmake looks like this:


####### Expanded from @PACKAGE_INIT@ by configure_package_config_file() #######
####### Any changes to this file will be overwritten by the next CMake run ####
####### The input file was libssh-config.cmake.in                            ########

get_filename_component(PACKAGE_PREFIX_DIR "${CMAKE_CURRENT_LIST_DIR}/../../../" ABSOLUTE)

macro(set_and_check _var _file)
  set(${_var} "${_file}")
  if(NOT EXISTS "${_file}")
    message(FATAL_ERROR "File or directory ${_file} referenced by variable ${_var} does not exist !")
  endif()
endmacro()

macro(check_required_components _NAME)
  foreach(comp ${${_NAME}_FIND_COMPONENTS})
    if(NOT ${_NAME}_${comp}_FOUND)
      if(${_NAME}_FIND_REQUIRED_${comp})
        set(${_NAME}_FOUND FALSE)
      endif()
    endif()
  endforeach()
endmacro()

####################################################################################

if (EXISTS "${CMAKE_CURRENT_LIST_DIR}/CMakeCache.txt")
    # In tree build
    set_and_check(LIBSSH_INCLUDE_DIR "${CMAKE_CURRENT_LIST_DIR}/include")
    set_and_check(LIBSSH_LIBRARIES "${CMAKE_CURRENT_LIST_DIR}/lib/libssh.so")
else()
    set_and_check(LIBSSH_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include")
    set_and_check(LIBSSH_LIBRARIES "${PACKAGE_PREFIX_DIR}/lib/libssh.so")
endif()

# For backward compatibility
set(LIBSSH_LIBRARY ${LIBSSH_LIBRARIES})

mark_as_advanced(LIBSSH_LIBRARIES LIBSSH_LIBRARY LIBSSH_INCLUDE_DIR)

@matthewbauer
Copy link
Member

Maybe caused by this commit:

https://git.libssh.org/projects/libssh.git/commit/?id=aa899f8ec06e21980403526fdb979071ecd9a65e

@worldofpeace worldofpeace mentioned this pull request Apr 22, 2019
Closed
@dtzWill
Copy link
Member

dtzWill commented Apr 23, 2019

3822b1d is an easy workaround, but hopefully we can come up with something better? :).

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 23, 2019 •
edited

The .pc file is wrong as well

Cflags: -I/nix/store/mv7grkl7hzmcnv83kagmj73sz298bsv9-libssh-0.8.7/include

And that's in the dev output.

@worldofpeace
Copy link
Contributor

3822b1d is an easy workaround, but hopefully we can come up with something better? :).

nix path-info before and after

  • 31.2M
  • 31.3M

You tell me 😄

@r-ryantm r-ryantm deleted the auto-update/libssh branch April 26, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@r-ryantm @markuskowa @xeji @matthewbauer @dtzWill @worldofpeace @FRidh @infinisil @GrahamcOfBorg