Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 409b46d8369d
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9f9465230ffd
Choose a head ref
  • 17 commits
  • 21 files changed
  • 10 contributors

Commits on Mar 26, 2019

  1. Switch homepage for turses to louipc fork

    The original repo is gone.
    
    (cherry picked from commit c59d2d3)
    booxter committed Mar 26, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7aa9d09 View commit details
  2. turses: fix crash when starting with existing config file

    Fixes #57460
    
    (cherry picked from commit 6f525a5)
    booxter committed Mar 26, 2019
    Copy the full SHA
    1502534 View commit details
  3. avahi: apply patches for CVE-2017-6519 & CVE-2018-1000845

    (cherry picked from commit 87a7622)
    andir committed Mar 26, 2019
    Copy the full SHA
    36314bd View commit details
  4. gitlab: 11.7.5 -> 11.8.2

    (cherry picked from commit 0ba98bb)
    bgamari authored and flokli committed Mar 26, 2019
    Copy the full SHA
    5269ccf View commit details
  5. gitlab: 11.8.2 -> 11.9.0

    (cherry picked from commit d8c16f1)
    bgamari authored and flokli committed Mar 26, 2019
    Copy the full SHA
    779d204 View commit details
  6. gitlab-shell: export GOCACHE in the installPhase

    TMPDIR, in `GOCACHE = "$TMPDIR";`, will not be intepreted  when it's set
    outside of a phase.
    
    (cherry picked from commit 483d823)
    kalbasit authored and flokli committed Mar 26, 2019
    Copy the full SHA
    3c11d7a View commit details
  7. nixos/gitlab: improved test to check download of repository archives

    (cherry picked from commit 968d3c9)
    Johan Thomsen authored and flokli committed Mar 26, 2019
    Copy the full SHA
    d237e19 View commit details
  8. nixos/gitlab: added gzip and bzip2 as dependencies for gitaly

    (cherry picked from commit 292c1ce)
    Johan Thomsen authored and flokli committed Mar 26, 2019
    Copy the full SHA
    5831439 View commit details
  9. gitlab: 11.9.0 -> 11.9.1

    (cherry picked from commit dcac21bb15f8188f1e7ae87d57207308f86dd5f8)
    flokli committed Mar 26, 2019
    Copy the full SHA
    4a5cac7 View commit details
  10. Merge pull request #58413 from flokli/19.03-gitlab-11.9.1

    [19.03] gitlab 11.7.5 -> 11.9.1, backport of more fixes and test improvements
    flokli authored Mar 26, 2019
    Copy the full SHA
    7f8da4d View commit details
  11. Merge pull request #58408 from andir/19.03/avahi

    avahi: apply patches for CVE-2017-6519 & CVE-2018-1000845
    flokli authored Mar 26, 2019
    Copy the full SHA
    08abce5 View commit details

Commits on Mar 27, 2019

  1. nixos/security: make duo support secure failure correctly

    seems that this got broken when the config option was made to use enums. "secure" got replaced with "enum", which isn't a valid option for the failure mode.
    
    (cherry picked from commit 0c34b9f)
    reanimus authored and infinisil committed Mar 27, 2019
    Copy the full SHA
    02cd553 View commit details
  2. pythonPackages.pyarrow: fix build

    Setting setupPyBuildFlags makes builder add an additional target
    "build_ext" to setup.py arguments in addition to "bdisst_wheel".
    pyarrow's setup.py recently started to try to redo build_ext again which
    broke the build.
    
    (cherry picked from commit 49e9194)
    veprbl committed Mar 27, 2019
    Copy the full SHA
    62b686a View commit details
  3. pythonPackages.pyarrow: enable parallel build

    (cherry picked from commit 55223a8)
    veprbl committed Mar 27, 2019
    Copy the full SHA
    afd5e8c View commit details
  4. pyarrow: remove tests that can break on darwin

    (cherry picked from commit 2645454)
    veprbl committed Mar 27, 2019
    Copy the full SHA
    8de4148 View commit details
  5. performous: fix build by using boost 166 (#58418)

    (cherry picked from commit 910c1d0)
    ajs124 authored and veprbl committed Mar 27, 2019
    Copy the full SHA
    42fece1 View commit details
  6. Merge pull request #58385 from booxter/release-19.03-turses-fix

    turses: fix crash when starting with existing config file
    infinisil authored Mar 27, 2019
    Copy the full SHA
    9f94652 View commit details
2 changes: 1 addition & 1 deletion nixos/modules/security/duosec.nix
Original file line number Diff line number Diff line change
@@ -76,7 +76,7 @@ in
};

failmode = mkOption {
type = types.enum [ "safe" "enum" ];
type = types.enum [ "safe" "secure" ];
default = "safe";
description = ''
On service or configuration errors that prevent Duo
2 changes: 2 additions & 0 deletions nixos/modules/services/misc/gitlab.nix
Original file line number Diff line number Diff line change
@@ -515,6 +515,8 @@ in {
gitAndTools.git
cfg.packages.gitaly.rubyEnv
cfg.packages.gitaly.rubyEnv.wrappedRuby
gzip
bzip2
];
serviceConfig = {
Type = "simple";
36 changes: 33 additions & 3 deletions nixos/tests/gitlab.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# This test runs gitlab and checks if it works

let
initialRootPassword = "notproduction";
in
import ./make-test.nix ({ pkgs, lib, ...} : with lib; {
name = "gitlab";
meta = with pkgs.stdenv.lib.maintainers; {
@@ -27,7 +30,7 @@ import ./make-test.nix ({ pkgs, lib, ...} : with lib; {
services.gitlab = {
enable = true;
databasePassword = "dbPassword";
initialRootPassword = "notproduction";
inherit initialRootPassword;
smtp.enable = true;
secrets = {
secret = "secret";
@@ -69,7 +72,27 @@ import ./make-test.nix ({ pkgs, lib, ...} : with lib; {
};
};

testScript = ''
testScript =
let
auth = pkgs.writeText "auth.json" (builtins.toJSON {
grant_type = "password";
username = "root";
password = initialRootPassword;
});

createProject = pkgs.writeText "create-project.json" (builtins.toJSON {
name = "test";
});

putFile = pkgs.writeText "put-file.json" (builtins.toJSON {
branch = "master";
author_email = "author@example.com";
author_name = "Firstname Lastname";
content = "some content";
commit_message = "create a new file";
});
in
''
$gitlab->start();
$gitlab->waitForUnit("gitaly.service");
$gitlab->waitForUnit("gitlab-workhorse.service");
@@ -78,6 +101,13 @@ import ./make-test.nix ({ pkgs, lib, ...} : with lib; {
$gitlab->waitForFile("/var/gitlab/state/tmp/sockets/gitlab.socket");
$gitlab->waitUntilSucceeds("curl -sSf http://gitlab/users/sign_in");
$gitlab->succeed("curl -isSf http://gitlab | grep -i location | grep -q http://gitlab/users/sign_in");
$gitlab->succeed("${pkgs.sudo}/bin/sudo -u gitlab -H gitlab-rake gitlab:check 1>&2")
$gitlab->succeed("${pkgs.sudo}/bin/sudo -u gitlab -H gitlab-rake gitlab:check 1>&2");
$gitlab->succeed("echo \"Authorization: Bearer \$(curl -X POST -H 'Content-Type: application/json' -d @${auth} http://gitlab/oauth/token | ${pkgs.jq}/bin/jq -r '.access_token')\" >/tmp/headers");
$gitlab->succeed("curl -X POST -H 'Content-Type: application/json' -H @/tmp/headers -d @${createProject} http://gitlab/api/v4/projects");
$gitlab->succeed("curl -X POST -H 'Content-Type: application/json' -H @/tmp/headers -d @${putFile} http://gitlab/api/v4/projects/1/repository/files/some-file.txt");
$gitlab->succeed("curl -H @/tmp/headers http://gitlab/api/v4/projects/1/repository/archive.tar.gz > /tmp/archive.tar.gz");
$gitlab->succeed("curl -H @/tmp/headers http://gitlab/api/v4/projects/1/repository/archive.tar.bz2 > /tmp/archive.tar.bz2");
$gitlab->succeed("test -s /tmp/archive.tar.gz");
$gitlab->succeed("test -s /tmp/archive.tar.bz2");
'';
})
13 changes: 10 additions & 3 deletions pkgs/applications/networking/instant-messengers/turses/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, python36Packages }:
{ stdenv, fetchpatch, python36Packages }:

with stdenv.lib;

@@ -19,14 +19,21 @@ buildPythonPackage rec {
checkInputs = [ mock pytest coverage tox ];
propagatedBuildInputs = [ urwid tweepy future ];

patches = [
(fetchpatch {
url = "https://github.com/louipc/turses/commit/be0961b51f502d49fd9e2e5253ac130e543a31c7.patch";
sha256 = "17s1n0275mcj03vkf3n39dmc09niwv4y7ssrfk7k3vqx22kppzg3";
})
];

checkPhase = ''
TMP_TURSES=`echo turses-$RANDOM`
mkdir $TMP_TURSES
PYTHONPATH=tests:$PYTHONPATH HOME=$TMP_TURSES py.test tests/
rm -rf $TMP_TURSES
'';

patchPhase = ''
postPatch = ''
sed -i -e 's|urwid==1.3.0|urwid==${getVersion urwid}|' setup.py
sed -i -e "s|future==0.14.3|future==${getVersion future}|" setup.py
sed -i -e "s|tweepy==3.3.0|tweepy==${getVersion tweepy}|" setup.py
@@ -35,7 +42,7 @@ buildPythonPackage rec {
'';

meta = with stdenv.lib; {
homepage = https://github.com/alejandrogomez/turses;
homepage = https://github.com/louipc/turses;
description = "A Twitter client for the console";
license = licenses.gpl3;
maintainers = with maintainers; [ garbas ];
36 changes: 18 additions & 18 deletions pkgs/applications/version-management/gitlab/data.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
{
"ce": {
"version": "11.7.5",
"repo_hash": "0bbyx9zmscf9273fgypb82gw166psy7d3p7dnwb6f5r9yz7rmhbn",
"deb_hash": "1m6hdvrz467q33z626l9f3d5pssl0bbj2hkqy5g0b05wvdznmldy",
"deb_url": "https://packages.gitlab.com/gitlab/gitlab-ce/packages/debian/stretch/gitlab-ce_11.7.5-ce.0_amd64.deb/download.deb",
"version": "11.9.1",
"repo_hash": "11dx931n79ynw8j6vbjsb832dkkp2s4vzji53km4ib9njn5nja0l",
"deb_hash": "133qjxmrn2rl9avi0nwcdbky53vgxbzp4g3vcgwg21xyfr8k8s4n",
"deb_url": "https://packages.gitlab.com/gitlab/gitlab-ce/packages/debian/stretch/gitlab-ce_11.9.1-ce.0_amd64.deb/download.deb",
"owner": "gitlab-org",
"repo": "gitlab-ce",
"rev": "v11.7.5",
"rev": "v11.9.1",
"passthru": {
"GITALY_SERVER_VERSION": "1.12.2",
"GITLAB_PAGES_VERSION": "1.3.1",
"GITLAB_SHELL_VERSION": "8.4.4",
"GITLAB_WORKHORSE_VERSION": "8.0.2"
"GITALY_SERVER_VERSION": "1.27.1",
"GITLAB_PAGES_VERSION": "1.5.0",
"GITLAB_SHELL_VERSION": "8.7.1",
"GITLAB_WORKHORSE_VERSION": "8.3.1"
}
},
"ee": {
"version": "11.7.5",
"repo_hash": "05dzvqrdgxbzsrf9rbis5m3iic04midx2arxgg3g4f78qfjxzylm",
"deb_hash": "1nfd68vzy3zc6a3xn5lhr83kqv9d7aaxvzv4ca9awcz4va5b33kc",
"deb_url": "https://packages.gitlab.com/gitlab/gitlab-ee/packages/debian/stretch/gitlab-ee_11.7.5-ee.0_amd64.deb/download.deb",
"version": "11.9.1",
"repo_hash": "13d6vg505rifgxpks9b7x2zq65b41naj7znkzm5i1kdvklfygqpd",
"deb_hash": "1z5i04cxwgcmx55yzhpw0ss1rwaqz1jl6hwpgbyly6prrbl5h59x",
"deb_url": "https://packages.gitlab.com/gitlab/gitlab-ee/packages/debian/stretch/gitlab-ee_11.9.1-ee.0_amd64.deb/download.deb",
"owner": "gitlab-org",
"repo": "gitlab-ee",
"rev": "v11.7.5-ee",
"rev": "v11.9.1-ee",
"passthru": {
"GITALY_SERVER_VERSION": "1.12.2",
"GITLAB_PAGES_VERSION": "1.3.1",
"GITLAB_SHELL_VERSION": "8.4.4",
"GITLAB_WORKHORSE_VERSION": "8.0.2"
"GITALY_SERVER_VERSION": "1.27.1",
"GITLAB_PAGES_VERSION": "1.5.0",
"GITLAB_SHELL_VERSION": "8.7.1",
"GITLAB_WORKHORSE_VERSION": "8.3.1"
}
}
}
12 changes: 10 additions & 2 deletions pkgs/applications/version-management/gitlab/gitaly/Gemfile
Original file line number Diff line number Diff line change
@@ -3,17 +3,18 @@ source 'https://rubygems.org'
# Require bundler >= 1.16.5 to avoid this bug: https://github.com/bundler/bundler/issues/6537
gem 'bundler', '>= 1.16.5'

gem 'rugged', '~> 0.27'
gem 'rugged', '~> 0.28'
gem 'github-linguist', '~> 6.1', require: 'linguist'
gem 'gitlab-markup', '~> 1.6.5'
gem 'gitaly-proto', '~> 1.3.0'
gem 'gitaly-proto', '~> 1.13.0'
gem 'activesupport', '~> 5.0.2'
gem 'rdoc', '~> 4.2'
gem 'gitlab-gollum-lib', '~> 4.2', require: false
gem 'gitlab-gollum-rugged_adapter', '~> 0.4.4', require: false
gem 'grpc', '~> 1.15.0'
gem 'sentry-raven', '~> 2.7.2', require: false
gem 'faraday', '~> 0.12'
gem 'rbtrace', require: false

# Detects the open source license the repository includes
# This version needs to be in sync with GitLab CE/EE
@@ -27,4 +28,11 @@ group :development, :test do
gem 'rspec-parameterized', require: false
gem 'timecop', require: false
gem 'factory_bot', require: false
gem 'pry', '~> 0.12.2', require: false

# gitlab-shell spec gems
gem 'listen', '~> 0.5.0'
gem 'simplecov', '~> 0.9.0', require: false
gem 'vcr', '~> 4.0.0'
gem 'webmock', '~> 3.4.0'
end
57 changes: 47 additions & 10 deletions pkgs/applications/version-management/gitlab/gitaly/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -10,6 +10,8 @@ GEM
adamantium (0.2.0)
ice_nine (~> 0.11.0)
memoizable (~> 0.4.0)
addressable (2.5.2)
public_suffix (>= 2.0.2, < 4.0)
ast (2.4.0)
binding_of_caller (0.8.0)
debug_inspector (>= 0.0.1)
@@ -19,18 +21,22 @@ GEM
adamantium (~> 0.2.0)
equalizer (~> 0.0.9)
concurrent-ruby (1.1.3)
crack (0.4.3)
safe_yaml (~> 1.0.0)
crass (1.0.4)
debug_inspector (0.0.3)
diff-lcs (1.3)
docile (1.1.5)
equalizer (0.0.11)
escape_utils (1.2.1)
factory_bot (4.11.1)
activesupport (>= 3.0.0)
faraday (0.15.3)
multipart-post (>= 1.2, < 3)
ffi (1.10.0)
gemojione (3.3.0)
json
gitaly-proto (1.3.0)
gitaly-proto (1.13.0)
grpc (~> 1.0)
github-linguist (6.2.0)
charlock_holmes (~> 0.7.6)
@@ -58,29 +64,35 @@ GEM
gollum-grit_adapter (1.0.1)
gitlab-grit (~> 2.7, >= 2.7.1)
google-protobuf (3.6.1)
googleapis-common-protos-types (1.0.2)
googleapis-common-protos-types (1.0.3)
google-protobuf (~> 3.0)
grpc (1.15.0)
google-protobuf (~> 3.1)
googleapis-common-protos-types (~> 1.0.0)
hashdiff (0.3.8)
i18n (1.1.1)
concurrent-ruby (~> 1.0)
ice_nine (0.11.2)
json (2.1.0)
licensee (8.9.2)
rugged (~> 0.24)
listen (0.5.3)
memoizable (0.4.2)
thread_safe (~> 0.3, >= 0.3.1)
method_source (0.9.2)
mime-types (3.2.2)
mime-types-data (~> 3.2015)
mime-types-data (3.2018.0812)
mini_portile2 (2.3.0)
mini_portile2 (2.4.0)
minitest (5.11.3)
msgpack (1.2.6)
multi_json (1.13.1)
multipart-post (2.0.0)
nokogiri (1.8.5)
mini_portile2 (~> 2.3.0)
nokogiri (1.10.1)
mini_portile2 (~> 2.4.0)
nokogumbo (1.5.0)
nokogiri
optimist (3.0.0)
parallel (1.12.1)
parser (2.5.3.0)
ast (~> 2.4.0)
@@ -91,7 +103,15 @@ GEM
parser
unparser
procto (0.0.3)
pry (0.12.2)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
public_suffix (3.0.3)
rainbow (3.0.0)
rbtrace (0.4.11)
ffi (>= 1.0.6)
msgpack (>= 0.4.3)
optimist (>= 3.0.0)
rdoc (4.3.0)
rouge (3.3.0)
rspec (3.7.0)
@@ -121,13 +141,19 @@ GEM
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.0, >= 1.0.1)
ruby-progressbar (1.10.0)
rugged (0.27.5)
rugged (0.28.0)
safe_yaml (1.0.4)
sanitize (4.6.6)
crass (~> 1.0.2)
nokogiri (>= 1.4.4)
nokogumbo (~> 1.4)
sentry-raven (2.7.2)
sentry-raven (2.7.4)
faraday (>= 0.7.6, < 1.0)
simplecov (0.9.2)
docile (~> 1.1.0)
multi_json (~> 1.0)
simplecov-html (~> 0.9.0)
simplecov-html (0.9.0)
stringex (2.8.4)
thread_safe (0.3.6)
timecop (0.9.1)
@@ -142,6 +168,11 @@ GEM
equalizer (~> 0.0.9)
parser (>= 2.3.1.2, < 2.6)
procto (~> 0.0.2)
vcr (4.0.0)
webmock (3.4.2)
addressable (>= 2.3.6)
crack (>= 0.3.2)
hashdiff

PLATFORMS
ruby
@@ -151,21 +182,27 @@ DEPENDENCIES
bundler (>= 1.16.5)
factory_bot
faraday (~> 0.12)
gitaly-proto (~> 1.3.0)
gitaly-proto (~> 1.13.0)
github-linguist (~> 6.1)
gitlab-gollum-lib (~> 4.2)
gitlab-gollum-rugged_adapter (~> 0.4.4)
gitlab-markup (~> 1.6.5)
google-protobuf (~> 3.6)
grpc (~> 1.15.0)
licensee (~> 8.9.0)
listen (~> 0.5.0)
pry (~> 0.12.2)
rbtrace
rdoc (~> 4.2)
rspec
rspec-parameterized
rubocop (~> 0.50)
rugged (~> 0.27)
rugged (~> 0.28)
sentry-raven (~> 2.7.2)
simplecov (~> 0.9.0)
timecop
vcr (~> 4.0.0)
webmock (~> 3.4.0)

BUNDLED WITH
1.17.1
1.17.3
Original file line number Diff line number Diff line change
@@ -7,14 +7,14 @@ let
gemdir = ./.;
};
in buildGoPackage rec {
version = "1.12.2";
version = "1.27.0";
name = "gitaly-${version}";

src = fetchFromGitLab {
owner = "gitlab-org";
repo = "gitaly";
rev = "v${version}";
sha256 = "0pg3pm34jnssvh8m99d6w3ap1kn6kn3akqaa17zxv9y0xryvchpy";
sha256 = "0m96048nxbgdkly5rz9d21yz8dmgv1kqis98is5kdz5b1wmhz18r";
};

goPackagePath = "gitlab.com/gitlab-org/gitaly";
Loading