Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Package gitlab-rails #58284

Merged
merged 1 commit into from Mar 28, 2019
Merged

nixos/gitlab: Package gitlab-rails #58284

merged 1 commit into from Mar 28, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 25, 2019 •
edited

Motivation for this change

This utility (particularly gitlab-rails console) is packaged by GitLab
Omnibus and is used for diagnostics and maintenance operations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bgamari bgamari requested a review from infinisil as a code owner March 25, 2019 19:24
@bgamari bgamari mentioned this pull request Mar 25, 2019
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

@GrahamcOfBorg test gitlab

@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

gitlab-rails got lost somewhere - see GrahamcOfBorg's output:

https://logs.nix.ci/?attempt_id=b4003a27-669d-4271-b7ca-892f07abfc11&key=nixos%2Fnixpkgs.58284

flokli
flokli requested changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitlab-rails isn't defined anywhere.

@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

I recovered the missing derivation from 401eb52, added it to the commit and rebased. LMK if that looks good to you.

@bgamari
nixos/gitlab: Package gitlab-rails
af909b3 
This utility (particularly `gitlab-rails console`) is packaged by GitLab
Omnibus and is used for diagnostics and maintenance operations.
@bgamari
Copy link
Contributor Author

bgamari commented Mar 28, 2019

I just pushed a fixed commit. Thanks @flokli!

@flokli flokli merged commit aa2878c into NixOS:master Mar 28, 2019
@flokli
Copy link
Contributor

flokli commented Mar 28, 2019

backported to 19.03 in 34aeed1.

@srhb srhb mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @flokli @GrahamcOfBorg