Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchurl: use fetchurlBoot for zlib deps #58283

Merged
merged 1 commit into from Mar 26, 2019
Merged

fetchurl: use fetchurlBoot for zlib deps #58283

merged 1 commit into from Mar 26, 2019

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Mar 25, 2019

Ever since #56067 went in, I've been getting infinite recursion errors. I eventually tracked the problem down to zlib using fetchurl. This patch ensures that fetchurl zlib dependencies correctly use fetchurlBoot instead.

error: while evaluating the attribute 'buildCommand' of the derivation 'modules' at /mnt/home/dylan/nix/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
while evaluating the attribute 'patches' of the derivation 'perl-5.28.1' at /mnt/home/dylan/nix/nixpkgs/pkgs/development/interpreters/perl/default.nix:28:5:
while evaluating the attribute 'nativeBuildInputs' of the derivation '0001-Fix-missing-build-dependency-for-pods.patch' at /mnt/home/dylan/nix/nixpkgs/pkgs/build-support/fetchurl/default.nix:115:3:
while evaluating the attribute 'configureFlags' of the derivation 'curl-7.64.0' at /mnt/home/dylan/nix/nixpkgs/pkgs/tools/networking/curl/default.nix:27:3:
while evaluating the attribute 'buildInputs' of the derivation 'libssh2-1.8.1' at /mnt/home/dylan/nix/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:183:11:
while evaluating the attribute 'src' of the derivation 'zlib-1.2.11' at /mnt/home/dylan/nix/nixpkgs/pkgs/development/libraries/zlib/default.nix:8:3:
while evaluating the attribute 'nativeBuildInputs' of the derivation 'zlib-1.2.11.tar.gz' at /mnt/home/dylan/nix/nixpkgs/pkgs/build-support/fetchurl/default.nix:115:3:
infinite recursion encountered, at undefined position

This exact problem I'm seeing may be specific to a custom overlay using genericStdenv, but I'm honestly not sure why this isn't a problem for general builds too.

(Also includes a related fix to the curl postInstall to not reference a null libssh2.)

@matthewbauer matthewbauer merged commit e8c84d3 into NixOS:master Mar 26, 2019
@dylex dylex mentioned this pull request Aug 30, 2019
Merged
10 tasks
@dylex dylex deleted the bootzlib branch October 9, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dylex @matthewbauer @GrahamcOfBorg