Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagemagick7Big: Revert meta.broken to false #58414

Merged
merged 1 commit into from Mar 27, 2019
Merged

imagemagick7Big: Revert meta.broken to false #58414

merged 1 commit into from Mar 27, 2019

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Mar 26, 2019

Motivation for this change

imagemagickBig and imagemagick7Big were marked broken in #55634 due to #55118. #57313 fixed the bug but reverted the broken bit only on imagemagickBig. Revert it on imagemagick7Big too.

Cc: @erikarvstedt, @delroth

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
imagemagick7Big: Revert meta.broken to false
a2aba3a 
imagemagickBig and imagemagick7Big were marked broken in NixOS#55634 due
to NixOS#55118.  NixOS#57313 fixed the bug but reverted the broken bit only on
imagemagickBig.  Revert it on imagemagick7Big too.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@veprbl veprbl merged commit 0a88820 into NixOS:master Mar 27, 2019
@andersk andersk deleted the imagemagick7Big branch December 10, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @veprbl @GrahamcOfBorg