Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] gitlab 11.7.5 -> 11.9.1, backport of more fixes and test improvements #58413

Merged
merged 6 commits into from
Mar 26, 2019
Merged

[19.03] gitlab 11.7.5 -> 11.9.1, backport of more fixes and test improvements #58413

merged 6 commits into from
Mar 26, 2019
+825 −504

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 26, 2019 •
edited
Loading

Motivation for this change

This backports version bumps of gitlab and some recent improvements in the gitlab module and vm tests.

cc @bgamari @kalbasit @johanot @jslight90

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

bgamari and others added 6 commits March 26, 2019 23:03
@bgamari @flokli
gitlab: 11.7.5 -> 11.8.2
5269ccf 
(cherry picked from commit 0ba98bb)
@bgamari @flokli
gitlab: 11.8.2 -> 11.9.0
779d204 
(cherry picked from commit d8c16f1)
@kalbasit @flokli
gitlab-shell: export GOCACHE in the installPhase

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
3c11d7a 
TMPDIR, in `GOCACHE = "$TMPDIR";`, will not be intepreted  when it's set
outside of a phase.

(cherry picked from commit 483d823)
@flokli
nixos/gitlab: improved test to check download of repository archives
d237e19 
(cherry picked from commit 968d3c9)
@flokli
nixos/gitlab: added gzip and bzip2 as dependencies for gitaly
5831439 
(cherry picked from commit 292c1ce)
@flokli
gitlab: 11.9.0 -> 11.9.1
4a5cac7 
(cherry picked from commit dcac21bb15f8188f1e7ae87d57207308f86dd5f8)
@flokli flokli requested review from fpletz and globin March 26, 2019 22:19
@flokli flokli requested a review from infinisil as a code owner March 26, 2019 22:19
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 26, 2019
@flokli
Copy link
Contributor Author

flokli commented Mar 26, 2019

@GrahamcOfBorg test gitlab

This was referenced Mar 26, 2019
Merged
Merged
@flokli flokli merged commit 7f8da4d into NixOS:release-19.03 Mar 26, 2019
@flokli flokli deleted the 19.03-gitlab-11.9.1 branch March 26, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@globin globin

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @GrahamcOfBorg @bgamari @kalbasit