Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evince: enable all features #58259

Closed
wants to merge 5 commits into from
Closed

evince: enable all features #58259

wants to merge 5 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Mar 25, 2019

Motivation for this change

I could no longer open postscript files in evince. While I was at it, I also enabled all other formats (DVI, XPS, PDF multimedia) as well as the nautilus extension. (The only features not enabled now are the browser plugin, the API docs, and the thumbnail cache.)

There is a slight increase in closure size (probably due to the gstreamer/nautilus dependency):

 nix path-info -shS result/ (which evince)   Mon 25 Mar 2019 03:35:30 PM CET
/nix/store/kd01ji4sb5pgnrjs3lzvgi3c279f1mjd-evince-3.30.2         11.2M  954.3M
/nix/store/rcy2ii19gx1mkqxzvr20jkj2jdzp83n1-evince-3.30.2         11.0M  420.4M

Many of these dependencies are probably already in the system closure (e.g. nautilus depends on gstreamer as well). We could add an evinceLight version that disables some/most features.

cc @jtojnar @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member Author

gebner commented Mar 25, 2019

The postscript fix needs to be backported to the release branch as well.

worldofpeace
worldofpeace reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've began work on getting gnome 3.32 so this will conflict with that.

I don't see too much of a problem with this aside from enabling the nautilus plugin by default.
(nautilus isn't present everywhere this is used)

I'd also like to enable meson for this (that'll change all the flags).

@worldofpeace
Copy link
Contributor

The postscript fix needs to be backported to the release branch as well.

Does that mean you want this change for 19.03 directly?

You should probably make this pr against 19.03 then, as my comment above won't be a problem.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Mar 25, 2019
@gebner
Copy link
Member Author

gebner commented Mar 25, 2019

The postscript fix needs to be backported to the release branch as well.
Does that mean you want this change for 19.03 directly?
You should probably make this pr against 19.03 then, as my comment above won't be a problem.

Postscript support used to work in 18.09; so I'd like to see this regression fixed soon and also for the 19.03 release.

I could make one PR just for the postscript fix for master/19.03, and then make the other changes against the 3.32 branch (including meson migration if you want). @worldofpeace Does that work for you?

@gebner
Copy link
Member Author

gebner commented Mar 25, 2019

I don't see too much of a problem with this aside from enabling the nautilus plugin by default. (nautilus isn't present everywhere this is used)

Evince should work just fine even if you don't use nautilus. The flag just builds an extension for nautilus, which shows additional file properties.

Are you concerned about the increase in closure size? I don't really need the extension, but it is an easy addition which is hard to build otherwise.

@jtojnar
Copy link
Contributor

jtojnar commented Mar 25, 2019 via email •
edited

@worldofpeace
Copy link
Contributor

My actual problem with the extension can be seen at #32817.
We're yet to implement that, which is why I think it was disabled.

Though I think we should be fine to fix this just for 19.03

@worldofpeace
Copy link
Contributor

😄 Looks like we responded at the same time.

@gebner
Copy link
Member Author

gebner commented Mar 25, 2019

Ok, I pushed just the postscript bugfix to 19.03 and master now. I'll make a new PR against gnome-3.32 that enables the other backends but keeps the nautilus extension disabled for now.

@gebner gebner closed this Mar 25, 2019
@gebner gebner mentioned this pull request Mar 25, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gebner @worldofpeace @jtojnar @GrahamcOfBorg