Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.nevow, tahoe-lafs: fix build #58429

Merged
merged 2 commits into from Mar 28, 2019
Merged

python2Packages.nevow, tahoe-lafs: fix build #58429

merged 2 commits into from Mar 28, 2019

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 27, 2019

Motivation for this change

#56826 - please backport

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh as a code owner March 27, 2019 11:00
@Mic92
Copy link
Member

Mic92 commented Mar 27, 2019

@GrahamcOfBorg build python2Packages.nevow

@dotlambda
Copy link
Member

The same needs to be done for tahoe-lafs.

@xeji
Copy link
Contributor Author

xeji commented Mar 27, 2019

@dotlambda: thanks for catching this, done
@GrahamcOfBorg build tahoe-lafs

@xeji xeji changed the title python2Packages.nevow: fix build python2Packages.nevow, tahoe-lafs: fix build Mar 27, 2019
@xeji
Copy link
Contributor Author

xeji commented Mar 27, 2019

tahoe-lafs: aarch64 failure is unrelated (dependency openblas).

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 28, 2019
@dotlambda dotlambda merged commit ef6a1b7 into NixOS:master Mar 28, 2019
@dotlambda
Copy link
Member

backported in f7ef8ac and 8706f44

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
@xeji xeji deleted the p/nevow branch February 17, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xeji @Mic92 @dotlambda @samueldr @GrahamcOfBorg