Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim plugin vim-beancount #58329

Merged
merged 2 commits into from Apr 18, 2019
Merged

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

Needed beancount syntax support; added this to vim-plugins as per usual

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli
Copy link
Contributor Author

rebased onto master and added another plugin ... please feel free to shut me down if that's considered out of line on this project

@zimbatm
Copy link
Member

zimbatm commented Mar 30, 2019

@siriobalmelli can you remove the noise from the PR? git rebase origin/master && git push -f

@siriobalmelli siriobalmelli force-pushed the master-dev branch 2 times, most recently from c097590 to e4aa8f5 Compare April 5, 2019 20:06
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli
Copy link
Contributor Author

cleaned this up, and keep periodically rebasing and pushing ... bump?

@zimbatm zimbatm merged commit 5b2b8f9 into NixOS:master Apr 18, 2019
@zimbatm
Copy link
Member

zimbatm commented Apr 18, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants