Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyarrow: fix build #58326

Merged
merged 3 commits into from Mar 26, 2019
Merged

pythonPackages.pyarrow: fix build #58326

merged 3 commits into from Mar 26, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 26, 2019 •
edited

Motivation for this change

Fixes pyarrow build.
cc #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
pythonPackages.pyarrow: fix build
49e9194 
Setting setupPyBuildFlags makes builder add an additional target
"build_ext" to setup.py arguments in addition to "bdisst_wheel".
pyarrow's setup.py recently started to try to redo build_ext again which
broke the build.
@veprbl
pythonPackages.pyarrow: enable parallel build
55223a8
@veprbl veprbl requested a review from FRidh as a code owner March 26, 2019 04:12
@veprbl
Copy link
Member Author

veprbl commented Mar 26, 2019

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 26, 2019
@dotlambda
Copy link
Member

I've seen the tests failing to bind to 127.0.0.1:0 on Darwin several times, but not on Linux. I'm wondering whether that's due to some sandboxing.

@veprbl
Copy link
Member Author

veprbl commented Mar 26, 2019 •
edited

@GrahamcOfBorg build python2Packages.pyarrow python3Packages.pyarrow

edit: backported in:
62b686a
afd5e8c
8de4148

@veprbl veprbl merged commit 0eb2c19 into NixOS:master Mar 26, 2019
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 27, 2019
This was referenced Apr 2, 2019
Closed
Merged
@veprbl veprbl deleted the pr/pyarrow_fix_2 branch December 1, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @dotlambda @GrahamcOfBorg