Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: 0.2.39 -> 0.2.42 #58328

Merged
merged 1 commit into from Apr 4, 2019
Merged

ffsend: 0.2.39 -> 0.2.42 #58328

merged 1 commit into from Apr 4, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

https://github.com/timvisee/ffsend/releases/tag/v0.2.42

Add support for xsel instead of xclip on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Linux via the nixos/nix Docker image)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

In the Linux Docker image I tested both with and without the preferXsel arg.

@lilyball
ffsend: 0.2.39 -> 0.2.42
da484ca 
https://github.com/timvisee/ffsend/releases/tag/v0.2.42

Add support for `xsel` instead of `xclip` on Linux.
@lilyball
Copy link
Member Author

lilyball commented Apr 2, 2019

Is there something I can do to speed up the review times on package updates like this?

@marsam
Copy link
Contributor

marsam commented Apr 4, 2019

lgtm, 0.2.43 was released a few days ago. would you mind updating it?

@lilyball
Copy link
Member Author

lilyball commented Apr 4, 2019

@marsam 0.2.43 contains nothing of interest to us, it appears to be primarily focused around updating the package files used for other packaging systems. I can update this PR this evening if you think it's worth being on the "latest version" regardless whether that version contains relevant changes, but I can't do so right now.

@marsam marsam merged commit 526ba47 into NixOS:master Apr 4, 2019
@marsam
Copy link
Contributor

marsam commented Apr 4, 2019

0.2.43 contains nothing of interest to us [...]

Sure, no problem. Btw feel free to ping me if any PR gets stuck :)

Built and tested locally on Darwin and NixOS

@lilyball lilyball deleted the ffsend branch April 4, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilyball @marsam @infinisil @GrahamcOfBorg