Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poedit: 1.5.7 -> 2.2.1 #58367

Merged
merged 1 commit into from Mar 29, 2019
Merged

poedit: 1.5.7 -> 2.2.1 #58367

merged 1 commit into from Mar 29, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Mar 26, 2019 •
edited

Motivation for this change

poedit was not updated since 2013.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bignaux
Copy link
Contributor Author

bignaux commented Mar 26, 2019

@GrahamcOfBorg build poedit

@bignaux bignaux changed the title [WIP] poedit: 1.5.7 -> 2.2.1 poedit: 1.5.7 -> 2.2.1 Mar 28, 2019
@flokli
Copy link
Contributor

flokli commented Mar 29, 2019

@GrahamcOfBorg build poedit

@flokli
Copy link
Contributor

flokli commented Mar 29, 2019

@bignaux built and tested locally. poedit complains loudly and advises against about missing language detection and crowdin integration features.

Is that something we can easily enable, without adding too much runtime dependencies?

@bignaux
Copy link
Contributor Author

bignaux commented Mar 29, 2019

Not really, need cdl2 (an old framework https://github.com/CLD2Owners/cld2/ ) and cpptest from microsoft, to get such a poedit "pro" ( https://poedit.net/purchase ) that is not cheap and not testable for me. Really i don't care about this warning, i've used it on gscrabble, that's worked at least better than our 2013 build. Perfect is the enemy of good .

@flokli
Copy link
Contributor

flokli commented Mar 29, 2019

Sure, just wanted to ask. Thanks for working on this, merged :-)

@flokli flokli merged commit 58ba4dc into NixOS:master Mar 29, 2019
@bignaux bignaux deleted the poedit branch March 30, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bignaux @flokli @GrahamcOfBorg