Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bdf2psf: 1.190 -> 1.191 #58372

Merged
merged 1 commit into from Mar 27, 2019
Merged

bdf2psf: 1.190 -> 1.191 #58372

merged 1 commit into from Mar 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 26, 2019

@GrahamcOfBorg build gohufont

@7c6f434c
Copy link
Member

I think a direct fetch from cache has happenned.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 26, 2019

Seems like it, do you know what happened?

@7c6f434c
Copy link
Member

Oooh, it is a fixed-output derivation.

rnhmjoj
rnhmjoj approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forced the build of gohufont and tested it in a VM.

@7c6f434c 7c6f434c merged commit 947421f into NixOS:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @rnhmjoj @7c6f434c @GrahamcOfBorg