Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxmlb: 0.1.7 -> 0.1.8 #58373

Closed
wants to merge 1 commit into from
Closed

libxmlb: 0.1.7 -> 0.1.8 #58373

wants to merge 1 commit into from
+2 −2

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested a review from jtojnar March 26, 2019 16:00
@jtojnar
Copy link
Member

jtojnar commented Mar 26, 2019

hughsie/libxmlb@cee3c7d

@jtojnar
Copy link
Member

jtojnar commented Mar 26, 2019

Should we add installed tests?

@worldofpeace
Copy link
Contributor

Should we add installed tests?

I can do this, but looking at hughsie/libxmlb@365f598 I'd need another patch.
Should I opt for pr'ing an option upstream?

@jtojnar
Copy link
Member

jtojnar commented Mar 28, 2019

If we could get upstream to accept that, it would be very nice.

@worldofpeace
Copy link
Contributor

If we could get upstream to accept that, it would be very nice.

Right, and it's not like others haven't had something like that

nixpkgs/pkgs/development/libraries/xdg-desktop-portal/default.nix

Line 34 in 20aeed3

"installed_testdir=$(installedTests)/libexec/installed-tests/xdg-desktop-portal"

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@jtojnar jtojnar mentioned this pull request Apr 15, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Apr 17, 2019

Ping-- is this waiting on something (changes/decision/info)?

@jtojnar
Copy link
Member

jtojnar commented Apr 17, 2019

Adding libxmlb to #34987 can be acceptable alternative if no one has the capacity to do it at the moment.

@jtojnar jtojnar mentioned this pull request May 1, 2019
Merged
@jtojnar
Copy link
Member

jtojnar commented May 1, 2019

This has been merged now #60602

@apeyroux
Copy link
Member

apeyroux commented May 3, 2019

maybe close the pr ?

@aanderse aanderse closed this May 6, 2019
@dtzWill
Copy link
Member Author

dtzWill commented May 9, 2019

Thanks!

@dtzWill dtzWill deleted the update/libxmlb-0.1.8 branch May 9, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtzWill @jtojnar @worldofpeace @apeyroux @aanderse @infinisil @GrahamcOfBorg