Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beamPackages.hex: 0.17.1 -> 0.20.1 #58343

Merged
merged 1 commit into from Jul 3, 2019
Merged

beamPackages.hex: 0.17.1 -> 0.20.1 #58343

merged 1 commit into from Jul 3, 2019

Conversation

peterromfeldhk
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterromfeldhk
Copy link
Contributor Author

@ericbmerritt for some reason i did not get sha mismatch when trying it out (that how i usually get the actual one :) ). i did update it using nix-shell -p nix-prefetch-github --run 'nix-prefetch-github --rev 9fa9de6a54f8c0c712d656638a305da9291f2326 hexpm hex', but not sure why it did not complain about wrong sha?

@cw789 cw789 mentioned this pull request Jun 19, 2019
Closed
10 tasks
@cw789
Copy link
Contributor

cw789 commented Jun 19, 2019

Latest Version is now: v0.20.1 (Source)

cw789
cw789 suggested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@cw789 cw789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to edit PR to update hex to new v0.20.1.

pkgs/development/beam-modules/hex/default.nix Outdated Show resolved Hide resolved
pkgs/development/beam-modules/hex/default.nix Outdated Show resolved Hide resolved
@peterromfeldhk peterromfeldhk changed the title beamPackages.hex: 0.17.1 -> 0.19.0 beamPackages.hex: 0.17.1 -> 0.20.1 Jun 19, 2019
@cw789
Copy link
Contributor

cw789 commented Jun 21, 2019

I've tested this now as an overlay on my Alpine Linux + Nix setup.
Should be fine to merge.

@cw789
Copy link
Contributor

cw789 commented Jul 3, 2019

@NeQuissimus: Hello Tim, as you where the one who merged the last beamPackages.hex version upgrade PR, am I allowed to ask you how I can help to get this one merged?

@NeQuissimus NeQuissimus merged commit 05c9a3c into NixOS:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cw789 cw789 cw789 requested changes

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterromfeldhk @cw789 @NeQuissimus @infinisil @GrahamcOfBorg