Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools: add finalImageName parameter for pullImage #58345

Merged
merged 1 commit into from Mar 28, 2019
Merged

dockerTools: add finalImageName parameter for pullImage #58345

merged 1 commit into from Mar 28, 2019

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

I need to change image name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/pullImage/finalImageName branch from 39ceaf7 to 2afa55c Compare March 26, 2019 10:35
nlewo
nlewo previously requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the nixpkgs manual also?
Otherwise, LGTM

@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/pullImage/finalImageName branch from 2afa55c to 468df17 Compare March 26, 2019 18:35
@offlinehacker offlinehacker dismissed nlewo’s stale review March 26, 2019 18:39

Ok, manual updated

@nlewo
Copy link
Member

nlewo commented Mar 28, 2019

Thx

@nlewo nlewo merged commit dc3ed33 into NixOS:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@offlinehacker @nlewo @GrahamcOfBorg