Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.stdint: 0.5.0 -> 0.5.1 #58363

Merged
merged 1 commit into from
Mar 27, 2019
Merged

ocamlPackages.stdint: 0.5.0 -> 0.5.1 #58363

merged 1 commit into from
Mar 27, 2019
+8 −22

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Mar 26, 2019

Motivation for this change

I need the bugfixes present in 0.5.1

Things done

Notice that the build system has (unfortunately) been changed from makefile to jbuilder which is a
builder that's been deprecated already. Still, given the right command line dune (its successor)
manage to build the thing, if not without some warnings.
Also, the fstar compiler, that uses stdint, does not built ; but it's already broken in master (with the same error message).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip rev HEAD"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 26, 2019
@rixed
Copy link
Contributor Author

rixed commented Mar 27, 2019 •
edited
Loading

Rebased.
Note that zmq does not build in sandbox mode any longer on master (edit: at least on macos).

@GrahamcOfBorg GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 27, 2019
@vbgl
Copy link
Contributor

vbgl commented Mar 27, 2019

@GrahamcOfBorg build ocamlPackages.zmq-lwt fstar

@vbgl vbgl merged commit 1777055 into NixOS:master Mar 27, 2019
@rixed rixed deleted the stdint-0.5.1 branch March 27, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rixed @vbgl @GrahamcOfBorg