Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cd-hit: init at 4.8.1 #58362

Merged
merged 2 commits into from Jun 14, 2019
Merged

cd-hit: init at 4.8.1 #58362

merged 2 commits into from Jun 14, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Mar 26, 2019

Motivation for this change

Biology tool needed in our computing center (GRICAD)

Things done
  • [ X Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bzizou bzizou changed the title [cd-hit] init at 4.8.1 cd-hit: init at 4.8.1 Mar 26, 2019
aanderse
aanderse requested changes Apr 14, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the $out/bin folder there are many perl files, most some of which fail to execute as they cannot find the perl modules they depend on.

  • plot_2d.pl requires Image::Magick
  • FET.pl requires Text::NSP::Measures::2D::Fisher::right and clstr_list.pl
  • clstr_list_sort.pl and clstr_list.pl require Storable

pkgs/applications/science/biology/cd-hit/default.nix Outdated Show resolved Hide resolved
@bzizou
Copy link
Contributor Author

bzizou commented Apr 29, 2019

I'll check the dependencies problem of the perl files, asap (end of this week I think). Many thanks for this suggestion

@globin
Copy link
Member

globin commented May 18, 2019

ping @bzizou

@bzizou
Copy link
Contributor Author

bzizou commented May 21, 2019

pong @globin , sorry, I had some personal contingencies, so a bit late with almost every lines of my TODO list ;-)

@bzizou bzizou force-pushed the cd-hit branch 2 times, most recently from 320c9fe to 4b1fec6 Compare May 23, 2019 10:00
aanderse
aanderse requested changes Jun 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzizou Sorry for the delay this sorta fell off my radar. Just need the perl package in a separate commit and I think we're good to go... Do you agree @jtojnar?

pkgs/top-level/perl-packages.nix Show resolved Hide resolved
pkgs/applications/science/biology/cd-hit/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.TextNSP perldevelPackages.TextNSP cd-hit

@aanderse aanderse merged commit 4cb64db into NixOS:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 9.needs: reporter feedback 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bzizou @globin @aanderse @jtojnar @GrahamcOfBorg