Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerTools: add nix-prefetch-docker script #58360

Merged

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Have a sane way to get output hash for dockerTools.pullImage

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/nix-prefetch-docker branch from a03d6b9 to dcfaa20 Compare March 26, 2019 11:37
@GrahamcOfBorg GrahamcOfBorg added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 26, 2019
@offlinehacker offlinehacker requested a review from nlewo March 26, 2019 13:41
@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/nix-prefetch-docker branch from dcfaa20 to 3a4d3d4 Compare March 26, 2019 21:04
@nlewo
Copy link
Member

nlewo commented Mar 28, 2019

Yeah! Actually I'm working on something quite similar: nmattia/niv#34 ;)

I think we could expose this derivation in all-packages.nix. Something such as:

nix-prefetch-docker = callPackage build-support/docker/nix-prefectch-docker.nix {}

Otherwise I tried it and it's working fine.

@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/nix-prefetch-docker branch 2 times, most recently from 99fcd57 to 32b9957 Compare April 6, 2019 11:02
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 6, 2019
@offlinehacker
Copy link
Contributor Author

@nlewo i applied your suggestions

@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/nix-prefetch-docker branch from 32b9957 to a493e22 Compare April 6, 2019 12:15
@offlinehacker offlinehacker force-pushed the pkgs/dockerTools/nix-prefetch-docker branch from a493e22 to c1f0d19 Compare April 6, 2019 12:16
@offlinehacker
Copy link
Contributor Author

I also updated docs

@offlinehacker offlinehacker merged commit c087b60 into NixOS:master Apr 6, 2019
@offlinehacker offlinehacker deleted the pkgs/dockerTools/nix-prefetch-docker branch April 6, 2019 12:44
@nlewo
Copy link
Member

nlewo commented Apr 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants