Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.re2: fix build on darwin #58359

Merged
merged 1 commit into from Apr 2, 2019
Merged

ocamlPackages.re2: fix build on darwin #58359

merged 1 commit into from Apr 2, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 26, 2019

Motivation for this change

Fixes #58178

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 26, 2019
@vbgl
Copy link
Contributor Author

vbgl commented Mar 26, 2019

@GrahamcOfBorg build ocamlPackages.re2 ocamlPackages.email_message ocamlPackages.core_bench ocamlPackages.core_extended ocamlPackages.async_shell ocamlPackages.core_profiler

@vbgl vbgl mentioned this pull request Mar 26, 2019
Closed
@vbgl
Copy link
Contributor Author

vbgl commented Mar 27, 2019

@GrahamcOfBorg build ocamlPackages.re2

@vbgl
Copy link
Contributor Author

vbgl commented Mar 27, 2019

@GrahamcOfBorg build ocamlPackages.re2

@vbgl
Copy link
Contributor Author

vbgl commented Mar 28, 2019

@GrahamcOfBorg build ocamlPackages.re2

@vbgl
Copy link
Contributor Author

vbgl commented Mar 28, 2019

@GrahamcOfBorg build ocamlPackages.re2 ocamlPackages.email_message ocamlPackages.core_bench ocamlPackages.core_extended ocamlPackages.async_shell ocamlPackages.core_profiler

@anton-trunov
Copy link

I'd like to help with checking this on macOS. What should I do? Thanks. Disclaimer: I just started using Nix.

@vbgl
Copy link
Contributor Author

vbgl commented Mar 29, 2019

You can tweak your NIX_PATH environment variable to point to the head of this PR, e.g.,

NIX_PATH=nixpkgs=https://github.com/vbgl/nixpkgs/tarball/394aca4a71a45a3041cb275aae612641fb30ace0 nix-shell -p ocamlPackages.ocaml ocamlPackages.findlib ocamlPackages.re2

@vbgl vbgl merged commit a011299 into NixOS:master Apr 2, 2019
@vbgl vbgl deleted the ocaml-re2+fix-on-darwin branch April 2, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @anton-trunov @GrahamcOfBorg