ocaml-syslog: fix missing cmxa file #58435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
Mar 27, 2019
| @@ -15,6 +15,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = [ ocaml findlib ]; | |||
|
|
|||
| buildPhase = "make all opt"; | |||
There was a problem hiding this comment.
Please use buildFlags (see https://nixos.org/nixpkgs/manual/#build-phase).
Makefile does not produce native library by default.
rixed
force-pushed
the
ocaml-syslog-also-opt
branch
from
33465e0
to
b3876e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Makefile does not produce native library by default.
Added an explicit "make all opt" as other ocaml libs do.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)