Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontforge: 20170730 -> 20190317 #58415

Merged
merged 1 commit into from Apr 12, 2019
Merged

fontforge: 20170730 -> 20190317 #58415

merged 1 commit into from Apr 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2019

Motivation for this change

https://github.com/fontforge/fontforge/releases/tag/20190317

  • add zmq (collab), woff2 (format), readline (cli)
  • "just in case", keep determinism patching
  • fontforge-fonttools: replace with override enabling tools
    Don't see any reason to not include by default,
    so this might make more sense as an alias instead.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
fontforge: 20170730 -> 20190317
867564a 
https://github.com/fontforge/fontforge/releases/tag/20190317

* add zmq (collab), woff2 (format), readline (cli)
* "just in case", keep determinism patching
* fontforge-fonttools: replace with override enabling tools
  Don't see any reason to not include by default,
  so this might make more sense as an alias instead.
@dtzWill dtzWill requested review from 7c6f434c, abbradar and LnL7 and removed request for 7c6f434c and abbradar March 27, 2019 13:38
@7c6f434c
Copy link
Member

@GrahamcOfBorg build creep

@7c6f434c
Copy link
Member

@GrahamcOfBorg build tlwg ricty liberation-sans-narrow

@xeji
Copy link
Contributor

xeji commented Apr 11, 2019

@GrahamcOfBorg eval

@7c6f434c 7c6f434c merged commit 75b1c3a into NixOS:staging Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @7c6f434c @xeji @infinisil @GrahamcOfBorg