Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apitrace: 363 -> 572 (2017-04-21 -> 2019-03-26) #58439

Merged
merged 1 commit into from Apr 19, 2019
Merged

apitrace: 363 -> 572 (2017-04-21 -> 2019-03-26) #58439

merged 1 commit into from Apr 19, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 27, 2019

Motivation for this change

Bump! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • the gl* variants anyway
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c00w
Copy link
Contributor

c00w commented Apr 19, 2019

Looks good to me.

[X] reviewed the diff and commit messages
Well formed - pretty boring version bump
[X] made sure ofBorg build succeeded for all applicable platforms
It technically timed out for x86_64 linux, but it works on my box so I think that may be spurious
[X] run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)
nix-review worked, and the output binary could trace a command.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 19, 2019

Thanks!

@dtzWill dtzWill merged commit 87efa1f into NixOS:master Apr 19, 2019
@dtzWill dtzWill deleted the update/apitrace-2019 branch April 19, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @c00w @infinisil @GrahamcOfBorg