Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect costs in bridge list after joining an AI company #6667

Closed
DorpsGek opened this issue Jan 21, 2018 · 3 comments
Closed

Incorrect costs in bridge list after joining an AI company #6667

DorpsGek opened this issue Jan 21, 2018 · 3 comments
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Chaos03 opened the ticket and wrote:

After I start the simpleAI and join his company, the bridge selection window shows incorrect (too high) prices. The prices are right when I am in a separate company.

Attachments

Reported version: 1.7.1
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/6667
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 11, 2018 •
edited by TrueBrain
Loading

frosch wrote:

Caused by an optimisation when calculating cost of all bridges:
tunnelbridge_cmd.cpp:

 	/* for human player that builds the bridge he gets a selection to choose from bridges (DC_QUERY_COST)
 	 * It's unnecessary to execute this command every time for every bridge. So it is done only
 	 * and cost is computed in "bridge_gui.c". For AI, Towns this has to be of course calculated
 	 */
 	Company *c = Company::GetIfValid(company);
 	if (!(flags & DC_QUERY_COST) || (c != NULL && c->is_ai)) {
This comment was imported from FlySpray: https://bugs.openttd.org/task/6667#comment14869

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale Stale issues label Jan 5, 2019
@andythenorth andythenorth removed the stale Stale issues label Jan 24, 2019
@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 25, 2019
@LordAro
Copy link
Member

LordAro commented Mar 26, 2019

Seems to be a visual-only glitch as per frosch's previous comments, that you can only trigger by using cheats and switching companies. Perhaps not a bug (that we care about) ?

Sorry, something went wrong.

@stale stale bot removed the stale Stale issues label Mar 26, 2019
LordAro added a commit to LordAro/OpenTTD that referenced this issue Dec 31, 2019
@LordAro
Fix OpenTTD#6667: Also recalculate bridge costs for 'spectated' AI co…
5eeff1e 
…mpanies
@LordAro LordAro closed this as completed in ab90421 Jan 5, 2020
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@LordAro @douiwby
Fix OpenTTD#6667: Also recalculate bridge costs for 'spectated' AI co…
c482885 
…mpanies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@TrueBrain @andythenorth @LordAro @DorpsGek @frosch123