Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: fix gcc8 for cross-compiled targets #58313

Merged
merged 1 commit into from Mar 26, 2019
Merged

gcc: fix gcc8 for cross-compiled targets #58313

merged 1 commit into from Mar 26, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Mar 26, 2019 •
edited

Adds EXTRA_TARGET_FLAGS missing from 4120939.

Fixes #58164

Motivation for this change

This seems to have been a mistaken deletion that prevented gcc8 from compiling when the target platform is not the host.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx
gcc: fix gcc8 for cross-compiled targets
05b0411 
Adds EXTRA_TARGET_FLAGS missing from 4120939.

Fixes NixOS#58164
@matthewbauer matthewbauer merged commit 38a89c8 into NixOS:master Mar 26, 2019
@matthewbauer
Copy link
Member

Thanks!

@arcnmx arcnmx deleted the gcc-8-cross branch April 24, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcc8 can't cross-compile
4 participants
@arcnmx @matthewbauer @GrahamcOfBorg @Janik-Haag