Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yuzu: init at 2019-05-03 #58312

Closed
wants to merge 1 commit into from
Closed

yuzu: init at 2019-05-03 #58312

wants to merge 1 commit into from

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 26, 2019

Motivation for this change

Requested in #58176.

Yuzu doesn't have stable releases yet, so this is based on the current latest git revision.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth mentioned this pull request Mar 26, 2019
Closed
@ghost
Copy link

ghost commented May 6, 2019

Is there any blockers preventing this from being merged?

@veprbl
Copy link
Member

veprbl commented May 6, 2019

@microsofttakeover This needs to use libsForQt5.callPackage (https://nixos.org/nixpkgs/manual/#ssec-qt-applications), the rest is minor.

@delroth
Copy link
Contributor Author

delroth commented May 6, 2019

I'll try to spend some time on it tonight (CEST), it's just fallen off my radar recently. Sorry!

@delroth delroth changed the title yuzu: init at 2019-03-24 yuzu: init at 2019-05-03 May 6, 2019
aanderse
aanderse requested changes May 15, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny things. Thanks for packaging this 👍

pkgs/misc/emulators/yuzu/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/yuzu/default.nix Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 1, 2019

@aanderse

@aanderse
Copy link
Member

aanderse commented Jun 2, 2019

Odd... this failed to build for me locally:

hash mismatch in fixed-output derivation '/nix/store/b4nyzs0iy8xk2h730c8zmy35c475x4cz-source':
  wanted: sha256:0lvw1i3601ycc6ipnssq398hcgsaq2an91wic46ppd5qqlck50fi
  got:    sha256:1906ndyrpyd6jwklbw0s839glv4fp693qxb2sxsjdnimmxgd0l1k
cannot build derivation '/nix/store/8zvby1nfd477j2gifdq92mwp6ry9w4n3-yuzu-unstable-2019-05-03.drv': 1 dependencies couldn't be built
error: build of '/nix/store/8zvby1nfd477j2gifdq92mwp6ry9w4n3-yuzu-unstable-2019-05-03.drv' failed

@delroth
Copy link
Contributor Author

delroth commented Jun 2, 2019

That's odd, ofborg seems to have had no issues with it. I'm going to guess there's some hermeticity issues with keeping .git, but not keeping it breaks yuzu build. I think we're going to have to go with some custom patching for version detection :-(

@aanderse
Copy link
Member

@delroth Any update on this?

@delroth
Copy link
Contributor Author

delroth commented Jul 19, 2019

I don't have any updates. My assessment is that we'd need some amount of patching and/or upstream contributions to get this package to build reproducibly. I don't have the bandwidth to work on this at the moment or likely any time in the near future. I'll close this PR to clarify the status.

@delroth delroth closed this Jul 19, 2019
@JoshuaFern JoshuaFern mentioned this pull request Apr 21, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @veprbl @aanderse @GrahamcOfBorg