Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmmp: 1.2.5 -> 1.3.1 #58384

Merged
merged 1 commit into from Mar 26, 2019
Merged

qmmp: 1.2.5 -> 1.3.1 #58384

merged 1 commit into from Mar 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 26, 2019

Motivation for this change

cc @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor bjornfor merged commit ae02455 into NixOS:master Mar 26, 2019
@ghost
Copy link
Author

ghost commented Mar 26, 2019

@bjornfor Thank you!

@ghost ghost deleted the qmmp branch March 26, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants