Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chafa: init at 1.0.1 #58422

Merged
merged 1 commit into from Mar 30, 2019
Merged

chafa: init at 1.0.1 #58422

merged 1 commit into from Mar 30, 2019

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Mar 27, 2019 •
edited

Motivation for this change

I read about cool tool on reddit and thought we needed it packaged. it makes cool unicode approximations of images inside your terminal.
koi_terminal

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

infinisil
infinisil requested changes Mar 27, 2019
View reviewed changes
pkgs/tools/misc/chafa/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/chafa/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/chafa/default.nix Outdated Show resolved Hide resolved
@mogorman mogorman force-pushed the chafa-1.0.1 branch 2 times, most recently from 3a8c613 to b24fa95 Compare March 27, 2019 07:10
@mogorman
Copy link
Contributor Author

patch was required to build manpages.

@infinisil
Copy link
Member

@GrahamcOfBorg eval

@infinisil
Copy link
Member

@GrahamcOfBorg build chafa

@infinisil
Copy link
Member

Darwin failure should be easy to fix, look at how other derivations include ApplicationServices

@infinisil
Copy link
Member

Ahh, as @grahamc explained to me on IRC, the evaluation failure comes from the fact that you're using an alias docbook_xml_xslt in your code, but we'd like to not have any aliases in nixpkgs code directly (they are only provided for backwards compatibility), so you just need to replace that with the non-alias docbook_xsl

@ryantm
Copy link
Member

ryantm commented Mar 30, 2019

@GrahamcOfBorg build chafa

@ryantm ryantm merged commit aaae785 into NixOS:master Mar 30, 2019
@ryantm
Copy link
Member

ryantm commented Mar 30, 2019

Looks like this is similar to catimg.

@mogorman mogorman deleted the chafa-1.0.1 branch March 30, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mogorman @infinisil @ryantm @GrahamcOfBorg