New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cypress: init at 3.2.0 #58423
cypress: init at 3.2.0 #58423
Conversation
773b0de
to
e4d16c5
Compare
@@ -107,6 +107,11 @@ | |||
github = "acowley"; | |||
name = "Anthony Cowley"; | |||
}; | |||
acyuta108 = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate commit please.
e4d16c5
to
e1cdd79
Compare
|
||
stdenv.mkDerivation rec{ | ||
version = "3.2.0"; | ||
name = "cypress-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "cypress-${version}"; | |
pname = "cypress"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryantm Sure, I'll make the change as requested. I haven't found any documentation on how to maintain multiple versions of a package. In this case, We might need to move forward with 3.1.5 until We resolve the latest issue in 3.2.0 as reported by @macalinao. Can you point me in the right direction? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simplest thing is something like:
cypress = callPackage ../development/web/cypress/default.nix { };
cypress_3_1 = callPackage ../development/web/cypress/3.1.nix { };
Where cypress
is the latest version and cypress_3_1
is the earlier version needed by some specific package. Each would have their own derivation file to avoid breaking eachother.
homepage = https://www.cypress.io; | ||
license = licenses.mit; | ||
platforms = ["x86_64-linux"]; | ||
maintainers = with maintainers; [ erosennin tweber acyuta108 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erosennin @thorstenweber83 are you okay with being maintainers of this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure!
Hey @acyuta108 , thanks for making this package. I'm getting the following error:
It looks like it's |
Yes @macalinao , I am getting the same error. Unfortunately I believe is a Cypress issue. I discovered it last Friday, when I last tested right after my push and got the error. |
Yes it works with Electron. I can also confirm the same error happens when
using Chromium.
…On Sun, Mar 31, 2019 at 21:18 Acyuta ***@***.***> wrote:
Yes, I am getting the same error. Unfortunately I believe is a Cypress
issue. I discovered it last Friday, when I last tested right after my push
and got the error.
Try switching the browser to Electron and let me know if you still have
the issue.
Unfortunately if We don't figure this out before this package is to be
merged, I'll need to downgrade to Cypress 3.1.5, which worked just fine.
I have created a ticket
<cypress-io/cypress#3852> in Cypress to see if
they can help.
@thorstenweber83 <https://github.com/thorstenweber83> and @erosennin
<https://github.com/erosennin>, you guys are far more experience than me,
would you kindly take a look and see if something might have changed from
3.1.5 => 3.2.0 that we need to address when unpacking/unzipping and linking
the contents of the deb package from Cypress?
Thanks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58423 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAYfb1eLapTDurJMgFhfveUVl2RHIkzAks5vcYilgaJpZM4cM5cT>
.
|
Any progress on this? |
Motivation for this change
Missing package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)