Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: init at 3.2.0 #58423

Closed
wants to merge 2 commits into from
Closed

Conversation

acyuta108
Copy link

Motivation for this change

Missing package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -107,6 +107,11 @@
github = "acowley";
name = "Anthony Cowley";
};
acyuta108 = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate commit please.


stdenv.mkDerivation rec{
version = "3.2.0";
name = "cypress-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "cypress-${version}";
pname = "cypress";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryantm Sure, I'll make the change as requested. I haven't found any documentation on how to maintain multiple versions of a package. In this case, We might need to move forward with 3.1.5 until We resolve the latest issue in 3.2.0 as reported by @macalinao. Can you point me in the right direction? Thanks.

Copy link
Member

@ryantm ryantm Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplest thing is something like:

cypress = callPackage ../development/web/cypress/default.nix { };
cypress_3_1 = callPackage ../development/web/cypress/3.1.nix { };

Where cypress is the latest version and cypress_3_1 is the earlier version needed by some specific package. Each would have their own derivation file to avoid breaking eachother.

homepage = https://www.cypress.io;
license = licenses.mit;
platforms = ["x86_64-linux"];
maintainers = with maintainers; [ erosennin tweber acyuta108 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erosennin @thorstenweber83 are you okay with being maintainers of this package?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure!

@macalinao
Copy link
Contributor

Hey @acyuta108 , thanks for making this package. I'm getting the following error:

EACCES: permission denied, open '/home/igm/.config/Cypress/cy/production/browsers/chrome/interactive/CypressExtension/background.js'

It looks like it's chmodded to 0700, and it belongs to my user. Any ideas? Thanks!

@acyuta108
Copy link
Author

acyuta108 commented Apr 1, 2019

Yes @macalinao , I am getting the same error. Unfortunately I believe is a Cypress issue. I discovered it last Friday, when I last tested right after my push and got the error.
Try switching the browser to Electron and let me know if you still have the issue.
Unfortunately if We don't figure this out before this package is to be merged, I'll need to downgrade to Cypress 3.1.5, which worked just fine.
I have created a ticket in Cypress to see if they can help.
@thorstenweber83 and @erosennin, you guys are far more experience than me, would you kindly take a look and see if something might have changed from 3.1.5 => 3.2.0 that we need to address when unpacking/unzipping and linking the contents of the deb package from Cypress?
Thanks

@macalinao
Copy link
Contributor

macalinao commented Apr 1, 2019 via email

@mmahut
Copy link
Member

mmahut commented Jul 16, 2019

Any progress on this?

@mmahut mmahut mentioned this pull request Jul 16, 2019
10 tasks
@aanderse aanderse closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants