Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harfbuzz: 2.3.1 -> 2.4.0 #58560

Merged
merged 1 commit into from Apr 16, 2019
Merged

harfbuzz: 2.3.1 -> 2.4.0 #58560

merged 1 commit into from Apr 16, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 29, 2019

https://github.com/harfbuzz/harfbuzz/releases/tag/2.4.0
https://lists.freedesktop.org/archives/harfbuzz/2019-March/007277.html

Motivation for this change

harfbuzz, unicode 12 \o/!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Apr 11, 2019

@GrahamcOfBorg eval

matthiasbeyer
matthiasbeyer approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple hash-version bump.

@FRidh FRidh merged commit bcbbbf9 into NixOS:staging Apr 16, 2019
@FRidh FRidh mentioned this pull request Apr 16, 2019
Closed
@FRidh
Copy link
Member

FRidh commented Apr 17, 2019

Hash seems to have changed. Also, note that in PR's #58693 and #59533 the hashes are also different! I think we should just fetch from the Git repo
https://github.com/harfbuzz/harfbuzz

@jtojnar jtojnar mentioned this pull request Apr 17, 2019
Merged
10 tasks
@dtzWill dtzWill mentioned this pull request May 1, 2019
Closed
@dtzWill dtzWill deleted the update/harfbuzz-2.4.0 branch May 1, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @veprbl @FRidh @matthiasbeyer @infinisil @GrahamcOfBorg