Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wine{unstable,staging,mono,winetricks} #58506

Merged
merged 4 commits into from Apr 16, 2019
Merged

Update wine{unstable,staging,mono,winetricks} #58506

merged 4 commits into from Apr 16, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Mar 28, 2019 •
edited

Motivation for this change
  • wine{unstable,staging}: 4.2 -> 4.5
  • wine-mono: 4.7.5 -> 4.8.0
  • winetricks: 20181203 -> 20190310
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member Author

I tested wineWowPackages.unstable successfully

@tadeokondrak tadeokondrak mentioned this pull request Apr 3, 2019
Closed
10 tasks
tadeokondrak
tadeokondrak reviewed Apr 3, 2019
View reviewed changes
pkgs/misc/emulators/wine/sources.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/wine/sources.nix Outdated Show resolved Hide resolved
@tadeokondrak @nyanloutre
wine{unstable,staging}: 4.4 -> 4.5
b4850a9 
Co-Authored-By: nyanloutre <paul@nyanlout.re>
@nyanloutre
Copy link
Member Author

nyanloutre commented Apr 5, 2019 •
edited

If you want to test, I pushed some packages to cachix : https://nyanloutre.cachix.org/

  • wineWowPackages.unstable
  • wine
  • winetricks

@ikervagyok
Copy link
Contributor

why does it always take such a long time until wine updates get merged? wine 4.6 is already out (also staging). anyway - would you update and then we find someone to finally commit these changes?

@veprbl
Copy link
Member

veprbl commented Apr 15, 2019

@GrahamcOfBorg build wine winePackages.staging winePackages.full

@veprbl
Copy link
Member

veprbl commented Apr 15, 2019

cc maintainers @avnik @7c6f434c @bendlas @the-kenny

@nyanloutre
Copy link
Member Author

@veprbl the borg build usually timeout because wine is taking more than an hour to build

@veprbl
Copy link
Member

veprbl commented Apr 16, 2019

Passes nix-review, winemine works.

@veprbl veprbl merged commit 04ff994 into NixOS:master Apr 16, 2019
@nyanloutre
Copy link
Member Author

@ikervagyok I made a PR for 4.6 here : #59764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nyanloutre @ikervagyok @veprbl @tadeokondrak @infinisil @GrahamcOfBorg