Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cairo: fix cross #58507

Merged
merged 1 commit into from Apr 16, 2019
Merged

cairo: fix cross #58507

merged 1 commit into from Apr 16, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

I messed up when rebasing #58505 on staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien symphorien mentioned this pull request Mar 28, 2019
Closed
10 tasks
@grahamc
Copy link
Member

grahamc commented Mar 28, 2019

@GrahamcOfBorg eval

@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Mar 30, 2019
@infinisil
Copy link
Member

@GrahamcOfBorg eval

@FRidh FRidh merged commit 1f17cd9 into NixOS:staging Apr 16, 2019
@symphorien symphorien deleted the cairo-cross branch May 18, 2019 16:01
@symphorien symphorien restored the cairo-cross branch May 18, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@symphorien @grahamc @infinisil @veprbl @FRidh @GrahamcOfBorg