Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polyml: 5.7.1 -> 5.8 #58466

Merged
merged 2 commits into from Apr 9, 2019
Merged

polyml: 5.7.1 -> 5.8 #58466

merged 2 commits into from Apr 9, 2019

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 28, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar
Copy link
Member Author

Not sure if the HOL package also needs to be updated to use the new (old) polyml57.

maggesi
maggesi approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@maggesi maggesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jwiegley : Not sure why/if the derivation for Isabelle still depends on PolyML. It is already bundled in the distribution, isn't?

However, this should not stop from merging this particular PR.

@pSub pSub merged commit e80a667 into NixOS:master Apr 9, 2019
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the bump-polyml branch April 9, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggesi maggesi maggesi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @maggesi @pSub @GrahamcOfBorg