Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blur-effect: init at 1.1.3 #58566

Merged
merged 1 commit into from Apr 1, 2019
Merged

blur-effect: init at 1.1.3 #58566

merged 1 commit into from Apr 1, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 30, 2019

Motivation for this change

https://github.com/sonald/blur-effect

off-screen image blurring utility using OpenGL ES 3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Mar 31, 2019
Merged
10 tasks
worldofpeace
worldofpeace approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, I can blur an image.

@worldofpeace
Copy link
Contributor

Wait build on darwin failed like

-- Checking for modules 'gdk-pixbuf-2.0;libdrm;gbm;egl;glesv2'
--   No package 'libdrm' found
--   No package 'gbm' found

worldofpeace
worldofpeace suggested changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build on darwin (conditioned buildInputs?) or mark broken on that platform.

@romildo
Copy link
Contributor Author

romildo commented Apr 1, 2019

Fix build on darwin (conditioned buildInputs?) or mark broken on that platform.

Marked as broken on darwin.

@worldofpeace worldofpeace merged commit f1d7b51 into NixOS:master Apr 1, 2019
@romildo romildo deleted the upd.blur-effect branch April 1, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @worldofpeace @Ma27 @GrahamcOfBorg