New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgit: add support for default filters #58565
Conversation
17a417c
to
07c3e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split into two commits, one to fix the cgit filters and the other to add the nixos options.
I'm actually not sure adding the nixos options is a good idea. It's just feels like the start of a lot of maintenance work: why not add more and more options (eventually all)? For example, I personally use "about-filter", "source-filter" and "commit-filter", but this change only adds options for the first two. I guess I prefer to manage this directly in the transparent configText option. |
@bjornfor wrote:
Sure, it's done.
I agree, the two configuration lines generated by the added options could alternatively be put as an example for the |
Yes, having those lines as examples is a good idea. The 2nd commit should have prefix "nixos/cgit: [...]". |
Filters moved to example and module commit reworded. |
Thanks! |
Motivation for this change
This adds support for source code and about page filters that are shipped with cgit.
The new module options default to the previous behaviour.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)CC package maintainer: @bjornfor