Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcur2png: init at 0.7.1 #58564

Merged
merged 1 commit into from Apr 1, 2019
Merged

xcur2png: init at 0.7.1 #58564

merged 1 commit into from Apr 1, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Mar 30, 2019

Motivation for this change

https://github.com/eworm-de/xcur2png

xcur2png is a program which let you take PNG image from X cursor, and generate config-file which is reusable by xcursorgen. To put it simply, it is converter from X cursor to PNG image.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Mar 31, 2019
Merged
10 tasks
worldofpeace
worldofpeace reviewed Mar 31, 2019
View reviewed changes
pkgs/tools/graphics/xcur2png/default.nix Outdated
buildInputs = [
libpng
xorg.libXcursor
xorg.libXrender
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where was the need for xrender specified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libXcursor depends on libXrender and xcur2png depends on libXcursor. Without explicitly listing libXrender in buildInputs here, building xcur2png fails with the message:

checking for XCUR2PNG... configure: error: Package requirements (libpng >= 1.0.6 xcursor) were not met:

Package 'xproto', required by 'xcursor', not found

(In VoidLinux it also has this dependency.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, libXrender propagates

xorg.xorgproto
xorg.libX11

If you add those and drop libXrender I think we should be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for pointing that out.

@worldofpeace worldofpeace merged commit e89a4ec into NixOS:master Apr 1, 2019
@romildo romildo deleted the upd.xcur2png branch April 1, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @worldofpeace @GrahamcOfBorg