Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: 0.35.0 -> 1.0.0 #58475

Merged
merged 1 commit into from Mar 30, 2019
Merged

minikube: 0.35.0 -> 1.0.0 #58475

merged 1 commit into from Mar 30, 2019

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Mar 28, 2019

Motivation for this change

Bump minikube to version 1.0.0 πŸŽ‰ β€” default version for it is k8s 1.14.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@xeji xeji merged commit fd3fdc3 into NixOS:master Mar 30, 2019
@vdemeester vdemeester deleted the update-minikube branch March 31, 2019 10:03
fpletz pushed a commit that referenced this pull request Apr 2, 2019
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
(cherry picked from commit fd3fdc3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants