Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] kde-applications: 18.12.1 -> 18.12.3 #58468

Merged
merged 2 commits into from Mar 28, 2019
Merged

[19.03] kde-applications: 18.12.1 -> 18.12.3 #58468

merged 2 commits into from Mar 28, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Backporting #56155 was mentioned #56155 (comment)

@lheckemann
Since it's a minor version bump though I suppose we can still backport it to 19.03 after the branch-off.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added 6.topic: qt/kde 8.has: port to stable A PR already has a backport to the stable release. labels Mar 28, 2019
@worldofpeace
Copy link
Contributor Author

Going for it 😄

@worldofpeace worldofpeace merged commit ca720b3 into NixOS:release-19.03 Mar 28, 2019
@worldofpeace worldofpeace deleted the backport/kde-apps-18.12.3 branch March 28, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@dtzWill dtzWill Awaiting requested review from dtzWill

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @lheckemann @GrahamcOfBorg @nyanloutre