Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r-sys: remove obsolete dependency #58467

Merged
merged 1 commit into from Mar 28, 2019
Merged

r-sys: remove obsolete dependency #58467

merged 1 commit into from Mar 28, 2019

Conversation

mnacamura
Copy link
Contributor

Motivation for this change

Package sys does not require libapparmor jeroen/sys@4e9d208.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mnacamura mnacamura requested a review from peti as a code owner March 28, 2019 02:28
Mic92
Mic92 reviewed Mar 28, 2019
View reviewed changes
pkgs/development/r-modules/default.nix
@@ -424,7 +424,6 @@ let
showtext = [ pkgs.pkgconfig ];
spate = [ pkgs.pkgconfig ];
stringi = [ pkgs.pkgconfig ];
sys = [ pkgs.libapparmor ];
sysfonts = [ pkgs.pkgconfig ];
Copy link
Member

@Mic92 Mic92 Mar 28, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about our R infrastructure. Are these overrides only for a particular version of the module or do they affect multiple (and potentially older ones)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have more than one version of any given R package in Nixpkgs.

Generally speaking, those overrides affect the (one) package with that particular attribute name.

@peti peti merged commit 3c9ff30 into NixOS:master Mar 28, 2019
@mnacamura mnacamura deleted the r-sys branch April 6, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnacamura @peti @Mic92 @GrahamcOfBorg