Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] virtualenv: Update patch for 16.2.0 #58499

Merged
merged 1 commit into from Mar 29, 2019
Merged

[19.03] virtualenv: Update patch for 16.2.0 #58499

merged 1 commit into from Mar 29, 2019

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 28, 2019 •
edited

(Cherry-picked from 2556b7b)

Motivation for this change

I was affected by #57008 on 19.03 (23fd139) and backporting the fix by @glasserc from #57533 fixed the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from FRidh as a code owner March 28, 2019 18:06
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.virtualenv python3.pkgs.virtualenv

@dotlambda dotlambda merged commit a0bf1c5 into NixOS:release-19.03 Mar 29, 2019
@mweinelt mweinelt deleted the virtualenv/py_version_backport branch February 24, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mweinelt @dotlambda @GrahamcOfBorg @glasserc