pythonPackages.grpcio: fix build on Darwin #58456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Builds on Darwin have started to fail recently. This seems to be caused by a check in Makefile that verifies whether the system is able to build BoringSSL. This check attempts to compile test/build/boringssl.c, which is absent in PyPI archives of grpcio. This change builds the grpcio module directly from the grpc git repository, so that all the files that are necessary for checks are present. Affects NixOS#56826 since darwin builds of this derivation on nixpkgs-19.03 fail.
danieldk
force-pushed
the
grpcio-darwin-fix
branch
from
90dfbf9
to
715ec6e
Compare
danieldk
changed the title
|
@GrahamcOfBorg build pythonPackages.grpcio python3Packages.grpcio pythonPackages.grpcio-tools python3Packages.grpcio-tools python3Packages.tensorflow pythonPackages.tensorflow |
|
@danieldk Did you make upstream aware of this issue? @GrahamcOfBorg build pythonPackages.grpcio python3Packages.grpcio pythonPackages.grpcio-tools python3Packages.grpcio-tools python3Packages.tensorflow pythonPackages.tensorflow |
|
@dotlambda I'll do that! |
|
Done in grpc/grpc#18570 |
averelld
pushed a commit
to averelld/nixpkgs
that referenced
this pull request
Apr 7, 2019
vcunat
added a commit
that referenced
this pull request
Apr 7, 2019
(cherry picked from commit 780c2de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Builds on Darwin have started to fail recently. This seems to be caused
by a check in Makefile that verifies whether the system is able to build
BoringSSL. This check attempts to compile test/build/boringssl.c, which
is absent in PyPI archives of grpcio.
This change builds the grpcio module directly from the grpc git
repository, so that all the files that are necessary for checks are
present.
Affects #56826 since darwin builds of this derivation on nixpkgs-19.03
fail.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)