Skip to content

nixos/upower: remove package option #58455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

nixos/upower: remove package option #58455

wants to merge 2 commits into from
+5 −14

Conversation

worldofpeace
Copy link
Contributor

Haven't had another upower package in nixpkgs since 2a2cb83

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
nixos/upower: remove package option
a4b3b9d 
Haven't had another upower package in nixpkgs since 2a2cb83
@worldofpeace worldofpeace requested a review from infinisil as a code owner March 27, 2019 18:39
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 27, 2019
@infinisil
Copy link
Member

People can still set their own upower package though. While I dislike having such options when it doesn't make sense, I don't think we can just remove them like that.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Mar 27, 2019 •
edited
Loading

True, but are you saying if something was justified 5 years ago df95a8cc2f92 and causes rebuilds should have this option?

Or that we're not in our place yet to remove any until there's a consensus?

@aanderse
Copy link
Member

If you're going to remove an option you should use mkRemovedOptionModule too.

@worldofpeace
Copy link
Contributor Author

mkRemovedOptionModule

Thanks, was wondering if there was something like this.

@bb010g
Copy link
Contributor

bb010g commented Apr 5, 2019

Aren't package options valuable for users wanting to use non-standard versions in modules but not everywhere, like with a full package override?

@worldofpeace
Copy link
Contributor Author

No proper response here. Closing

@worldofpeace worldofpeace deleted the upower/no-package-option branch April 14, 2019 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@worldofpeace @infinisil @aanderse @bb010g @GrahamcOfBorg