Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brig: Fix build of metrics jobs, cleanup #58454

Merged
merged 2 commits into from Mar 27, 2019
Merged

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 27, 2019

Motivation for this change

The use of callPackages instead of callPackage caused the metrics job to fail with a rather cryptic error, because override and overrideAttrs were added to the meta attr.

Also removed apparently unused fetchgx arg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb changed the title brig: Various fixups brig: Fix eval of metrics jobs, cleanup Mar 27, 2019
@srhb srhb requested a review from offlinehacker March 27, 2019 18:41
@srhb srhb changed the title brig: Fix eval of metrics jobs, cleanup brig: Fix build of metrics jobs, cleanup Mar 27, 2019
@srhb srhb merged commit 431d8e3 into NixOS:master Mar 27, 2019
@srhb srhb deleted the brig-fix-metrics branch March 27, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants