Skip to content

ffmpeg: 3.4.5 -> 3.4.6 #58549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2019
Merged

ffmpeg: 3.4.5 -> 3.4.6 #58549

merged 1 commit into from
Mar 30, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 29, 2019

https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/0ac9001ab9f2bdd7c4306afd1a91d6c78b294d9f:/Changelog

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
greg-1-anderson Greg Anderson
@infinisil
Copy link
Member

Do you know why we have don't use ffmpeg_4 as the default ffmpeg version?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 29, 2019 via email

@flokli
Copy link
Contributor

flokli commented Mar 30, 2019

@dtzWill do you want to try out what breaks when we flip the default? ;-)

@flokli flokli merged commit d741262 into NixOS:master Mar 30, 2019
vcunat pushed a commit that referenced this pull request Jul 31, 2019
https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/0ac9001ab9f2bdd7c4306afd1a91d6c78b294d9f:/Changelog
(cherry picked from commit dfdacfd)
I don't know if any CVEs are filed against this, but it still seems
likely to fix more things than break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants